Page tree

Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Published by Scroll Versions from space CPPTDESKDEV and version 10.3.2

...

  • Post-commit: This mode is based on automatic identification of modifications in a source repository via custom source control interfaces. Review tasks are created based on a preconfigured mapping of changed code to reviewers.
  • Pre-commit: Users can initiate a code review from the desktop by selecting a set of files to distribute for the review, or automatically identify all locally changed source code.
  • Task-driven: Users can initiate a code review from the desktop by selecting files related to a particular Parasoft Project Center task. It does not matter whether or not these files have been committed to source control.

Code Review requires Team Server and at least one Parasoft Test Server Edition.

...

There are two key workflow variations: default vs. restricted and pre-commit vs. post-commit vs. task-driven.

Default vs. Restricted

In a restricted workflow, the reviewer must accept each issue. If the author does not agree with the reviewer’s suggestion, he needs to discuss this with the reviewer. 

The default workflow is more open: when the author receives comments from a reviewer, he can either apply them to the code, or leave the code as is.

Anchor
pre-commit
pre-commit

Pre-Commit vs. Post-Commit

...

Pre-Commit

Pre-commit code reviews are for teams who want to review code before adding it to source control. When developers are ready to have a piece of new/modified code reviewed, they run a Code Review Test Configuration from the Parasoft Test UI, then the reviewer is automatically notified about the required review. 

...

  • Generate emails notifying authors and reviewers about their assigned code review tasks.
  • Identify any code changes that were committed to source control, but were not submitted for review using the pre-commit procedure.

Task-Driven

Teams who are tracking tasks with Parasoft Concerto Project Center also have the option of a task-driven code review. This is a less restrictive workflow that allows team members to submit code for review as needed. Here, authors can submit all (or selected) files related to a particular task or set of tasks. It does not matter whether or not these files have been committed to source control (there can even be a mixture of committed and local files). With this process, code review packages are always created in the context of a task. 

For instance, if a developer has been working on a task and wants feedback on the work he’s done so far, he can submit the related files for review. He can submit all files related to a particular task, or designate the specific task-related files he wants reviewed at the current time. Or, an architect might be reviewing sprint progress and see that several different developers completed several key tasks for some critical new functionality. He could then select all of those tasks, and submit all related files for review.

Workflow Details

The following diagrams illustrate the key workflows available:

...

  • Pre-Commit: This Test Configuration is for teams who want to review code before it is committed to source control (see Pre-Commit vs. Post-Commit vs. Task-Driven). It scans files added or modified locally. To use this Test Configuration, the Code Review Preference Show user assistant during scanner run setting must be enabled so that the author can designate the appropriate reviewer(s).
  • Post-Commit (Template): This Test Configuration is for teams who want to review code after it is committed to source control (see Pre-Commit vs. Post-Commit vs. Task-Driven). It scans all project files modified in the previous day. This Test Configuration must be duplicated and customized prior to use (e.g, to specify author-reviewer mappings). See Configuring and Running Post-Commit Code Review Scans for details.

  • Post-Commit (Assign All):  This Test Configuration is for teams who want to review code after it is committed to source control (see Pre-Commit vs. Post-Commit vs. Task-Driven). It scans all project files modified in the previous day. It can be used without customization. It includes a mapping for the local code review user; it assigns all revisions found in scope (for any author) to the current user.Task-Commit (Assign All): This Test Configuration is for teams who want to their code reviews to be performed in the context of Parasoft Concerto Project Center tasks. It scans files added or modified locally. It can be used without customization. To use this Test Configuration, the

Code Review

...

Code Review Task / Status Reporting

Code Review tasks are reported in the GUI as described in Working with the Code Review UI. Code Review details are also provided in the Code Review section of reports generated from command line or GUI analysis. These reports provide an overview of code review tasks and issues per project and per author. It also provides details on pending issues and code review tasks.

...